[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 20 04:18:19 PDT 2020


MyDeveloperDay added a comment.

In D75791#2045986 <https://reviews.llvm.org/D75791#2045986>, @MarcusJohnson91 wrote:

> In D75791#2044492 <https://reviews.llvm.org/D75791#2044492>, @MyDeveloperDay wrote:
>
> > If you want me to land this for you, I'd feel more comfortable landing it if:
> >
> > a) We can land D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults <https://reviews.llvm.org/D80214> first
> >  b) The Mozilla team have tested the impact (they clang-format their entire code base I think)
>
>
> I'm ok with accepting commit access, and I agree lets get D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults <https://reviews.llvm.org/D80214> in, and see if Mozilla, Microsoft, Google, etc  has any comments; I'm just not sure of who to ping.
>
> Is there anything else that D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults <https://reviews.llvm.org/D80214> needs? it looked pretty well fleshed out.


I need an Accept on D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults <https://reviews.llvm.org/D80214> and I think @Abpostelnicu would have let us know if it failed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75791/new/

https://reviews.llvm.org/D75791





More information about the cfe-commits mailing list