[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 19 12:37:09 PDT 2020


njames93 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp:101-102
+
+void StringFindStrContainsCheck::storeOptions(
+    ClangTidyOptions::OptionMap &Opts) {
+  Options.store(Opts, "StringLikeClasses",
----------------
I don't know if you have rebased recently, but `TransformerClangTidyCheck` now has a `storeOptions` method that needs calling from derived classes that override `storeOptions`. For now can you add a call to that in here `TransformerClangTidyCheck::storeOptions(Opts);` I Agree that we need to rework how options are handled but for now, make it work correctly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80023/new/

https://reviews.llvm.org/D80023





More information about the cfe-commits mailing list