[clang] 268fa40 - [analyzer] Don't print the config count in debug.ConfigDumper

[Kirstóf Umann via cfe-commits]

Author: Kirstóf Umann
Date: 2020-05-19T16:51:14+02:00
New Revision: 268fa40daa151d3b4bff1df12b62e5dae94685d7

URL: https://github.com/llvm/llvm-project/commit/268fa40daa151d3b4bff1df12b62e5dae94685d7
DIFF: https://github.com/llvm/llvm-project/commit/268fa40daa151d3b4bff1df12b62e5dae94685d7.diff

LOG: [analyzer] Don't print the config count in debug.ConfigDumper

I think anyone who added a checker config wondered why is there a need
to test this. Its just a chore when adding a new config, so I removed
it.

To give some historic insight though, we used to not list **all**
options, but only those explicitly added to AnalyzerOptions, such as the
ones specified on the command line. However, past this change (and
arguably even before that) this line makes little sense.

There is an argument to be made against the entirety of
analyzer-config.c test file, but since this commit fixes some builtbots
and is landing without review, I wouldn't like to be too invasive.

Added: 
    

Modified: 
    clang/lib/StaticAnalyzer/Checkers/DebugCheckers.cpp
    clang/test/Analysis/analyzer-config.c

Removed: 
    


################################################################################
diff  --git a/clang/lib/StaticAnalyzer/Checkers/DebugCheckers.cpp b/clang/lib/StaticAnalyzer/Checkers/DebugCheckers.cpp
index e93c1e9b0a6a..03b7cbd1c833 100644
--- a/clang/lib/StaticAnalyzer/Checkers/DebugCheckers.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/DebugCheckers.cpp
@@ -281,8 +281,6 @@ class ConfigDumper : public Checker< check::EndOfTranslationUnit > {
       llvm::errs() << Keys[I]->getKey() << " = "
                    << (Keys[I]->second.empty() ? "\"\"" : Keys[I]->second)
                    << '\n';
-
-    llvm::errs() << "[stats]\n" << "num-entries = " << Keys.size() << '\n';
   }
 };
 }

diff  --git a/clang/test/Analysis/analyzer-config.c b/clang/test/Analysis/analyzer-config.c
index 3a6b4d20b1b1..85cd6738b6dc 100644
--- a/clang/test/Analysis/analyzer-config.c
+++ b/clang/test/Analysis/analyzer-config.c
@@ -107,5 +107,3 @@
 // CHECK-NEXT: unix.DynamicMemoryModeling:Optimistic = false
 // CHECK-NEXT: unroll-loops = false
 // CHECK-NEXT: widen-loops = false
-// CHECK-NEXT: [stats]
-// CHECK-NEXT: num-entries = 104