[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

Valeriy Savchenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 19 06:28:27 PDT 2020


vsavchenko added a comment.

Thanks for taking your time to find and resolve the bug.
I agree that this solution seems a bit too harsh.  Technically there is no difference between local variable declaration and a parameter declaration (if we are talking about value types as pointed out by @xazax.hun).
I believe that we should actually fix the //**will not find the variable declaration "VD" which lead to "llvm_unreachable"**// part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80171/new/

https://reviews.llvm.org/D80171





More information about the cfe-commits mailing list