[PATCH] D80202: [ASTMatchers] Performance optimization for memoization

Noel Grandin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 19 05:54:55 PDT 2020


grandinj added inline comments.


================
Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:78
+  const BoundNodesTreeBuilder &BoundNodes;
+  const TraversalKind Traversal;
+
----------------
note that making fields const tends to disable various move optimisations, so better to mark the whole struct const in code that uses it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80202/new/

https://reviews.llvm.org/D80202





More information about the cfe-commits mailing list