[PATCH] D79930: [clangd] Add buildPreamble to TestTU

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 19 04:17:33 PDT 2020


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/unittests/TestTU.h:71
   ParsedAST build() const;
+  std::shared_ptr<const PreambleData> buildPreamble() const;
   ParseInputs inputs() const;
----------------
or just preamble() to align with the functions below... depends whether we think build() is the special case or preamble is similar.
Up to you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79930/new/

https://reviews.llvm.org/D79930





More information about the cfe-commits mailing list