[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 19 03:45:14 PDT 2020


sammccall added a subscriber: ABataev.
sammccall added a comment.

This seems vaguely reasonable to me, but I don't really know what an OpenMP capture is.

@ABataev, @jdoerfert : Any thoughts or concerns here?
Some context: an expression that contains errors can exist after certain types of sema/parse errors and acts as a placeholder in the AST with unknown semantics, e.g. we often don't know what its type is.
It is modeled as dependent, but its value/type/validity depends on how an the user would correct the error rather than how a template is instantiated.
(This behavior is with the -recovery-ast flag, which will one day be default).

@hokein Callers of `isDependentContext()` might mike sense to audit for recovery-AST-safety as it gives fewer guarantees than it used to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80200/new/

https://reviews.llvm.org/D80200





More information about the cfe-commits mailing list