[PATCH] D80160: [Tooling] Drop leading/trailing whitespace from compile_flags.txt lines

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 19 02:40:28 PDT 2020


sammccall marked 2 inline comments as done.
sammccall added inline comments.


================
Comment at: clang/test/Tooling/fixed-database.cpp:6
 // RUN: cp "%S/Inputs/fixed-header.h" "%t/Include/"
+// RUN: echo '# this is a comment' >> %t/compile_flags.txt
 // -I flag is relative to %t (where compile_flags is), not Src/.
----------------
kadircet wrote:
> Not sure what this line is about, default comment marker is `\0` for `line_itearator` and we don't seem to be changing it.
Uh, this is a bad test, clang-check doesn't fail on driver errors and the compilation didn't depend on it.

And `#comments` would probably break something one day anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80160/new/

https://reviews.llvm.org/D80160





More information about the cfe-commits mailing list