[PATCH] D79967: Fix debug info for NoDebug attr

[Djordje Todorovic via Phabricator via cfe-commits]

djtodoro added a comment.

This seems reasonable, so this change looks good to me!

@dblaikie Thanks for pointing out to the potential problems of the usage of the func decl !dbg in the purpose of call sites debug info. It is currently being stored into CU's retainedTypes field.

> That's why DISubprogram moved to be attached to an llvm::Function (previously all DISubprograms were listed on the CU and DISubprograms pointed to llvm::Functions) to aid in LTO

Is it only one patch or a set of patches? I'll try to find these changes in the log history.

I am open for the discussion about redesigning it (please wait for a comment from @vsk as well). :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79967/new/

https://reviews.llvm.org/D79967