[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

[David Blaikie via Phabricator via cfe-commits]

dblaikie added subscribers: JDevlieghere, probinson, aprantl, echristo, dblaikie.
dblaikie added a comment.

This seems like a fairly invasive way to preserve certain DWARF types.

Are you in a position to make source changes to help here? Would it be reasonable to annotate these types with __attribute__((used)), for instance? I think it'd probably be useful on the compiler end to support using that attribute to communicate the need for that type to be emitted into the debug info - and that could be powered by adding the attributed type to the DICompileUnit's "retainedTypes" list.

(& even if attribute used can't be used in your case, because you need to deal with the code as it's currently written - perhaps this whole feature could be replaced with a front-end tweak to add these particular types to the retainedTypes list under the same conditions you're doing all this other stuff? Without the need for the synthetic function calls, pass to remove them, etc)

(also, when making changes for/to debug info - probably worth including either/at least the debug-info tag and/or some of the usual debug info contributors (myself, @echristo, @aprantl, @JDevlieghere, @probinson, etc))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74572/new/

https://reviews.llvm.org/D74572