[PATCH] D79938: [clangd] Add a flag to preserve type for recovery expression.

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1072
   ParseInput.Contents = std::string(Input.Contents);
+  // FIXME: setup the recoveryAST and recoveryASTType in ParseInput properly.
 
----------------
hokein wrote:
> unfortunately, we don't have the `ParseOptions` structure in code completion code path, maybe we can add two flags in `SemaCompleteInput`.
I think we should just make the public interface to `codeComplete` take ParseInputs, it's mostly overlap anyway


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79938/new/

https://reviews.llvm.org/D79938