[PATCH] D79961: [PGO] Fix computation of fuction Hash

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun May 17 12:15:15 PDT 2020


MaskRay added a comment.

This patch is correct. A clarification of the description:

> Previous implementation was incorrectly passing an integer, that got converted to a pointer, to finalize the hash computation.

Working (an `uint64_t`) was truncated to an `uint8_t`, converted to a one-element `ArrayRef<uint8_t>`, then passed to `MD5.update`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79961/new/

https://reviews.llvm.org/D79961





More information about the cfe-commits mailing list