[PATCH] D79655: [WebAssembly] Handle exception specifications

Fri May 15 21:54:14 PDT 2020

aheejin marked an inline comment as done.
aheejin added inline comments.

================
Comment at: clang/test/CodeGenCXX/wasm-eh.cpp:399

+// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions -fexceptions -fcxx-exceptions -fwasm-exceptions -target-feature +exception-handling -S -o - -std=c++11 | FileCheck %s --check-prefix=ASSEMBLY
+
----------------
dschuff wrote:
> aheejin wrote:
> > This was preexisting just moved
> Is it common in these tests to have RUN lines throughout the file instead of all together up at the top?
Not sure how common it is, but we have similar examples, such as https://github.com/llvm/llvm-project/blob/master/clang/test/Driver/wasm-toolchain.c. I moved them mainly for readability; because now we can check what prefix `WARNING`'s command line is like and what `WARNING`'s check lines like, and the same for `ASSEMBLY`. I don't have a strong opinion for this, so if you think it's better to merge them at the top, please let me know, I'll do that as a follow-up.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79655/new/

https://reviews.llvm.org/D79655