[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17
Artem Belevich via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 15 14:10:03 PDT 2020
tra added a comment.
LGTM in general. Let me check the patch on our tensorflow build.
================
Comment at: clang/test/SemaCUDA/constexpr-variables.cu:30-31
+ static constexpr int c = sizeof(a);
+ a[0] = &b;
+ a[1] = &c;
+ foo(a);
----------------
Can we verify the diags for bad cases, too?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79237/new/
https://reviews.llvm.org/D79237
More information about the cfe-commits
mailing list