[PATCH] D72534: Change default traversal in AST Matchers to ignore invisible nodes

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 15 06:28:50 PDT 2020


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from some documentation nits.



================
Comment at: clang/docs/ReleaseNotes.rst:255
+  This means that many uses of the ``ignoringImplicit()`` and similar matchers
+  is no longer necessary.  Clients of AST Matchers which wish to match on
+  implicit AST nodes can wrap their matcher in ``traverse(TK_AsIs, ...)`` or
----------------
is -> are

Also, I think we typically use single spacing after the full stop in the release notes.


================
Comment at: clang/docs/ReleaseNotes.rst:257-259
+  use ``TraversalKindScope`` if appropriate.  The ``clang-query`` tool also
+  uses ``IgnoreUnlessSpelledInSource`` by default.  The mode can be changed
+  using ``set traversal AsIs`` in the ``clang-query`` environment.
----------------
We also have release notes for clang-tools-extra that should be updated for the changes to clang-query.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72534/new/

https://reviews.llvm.org/D72534





More information about the cfe-commits mailing list