[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

Fri May 15 04:30:05 PDT 2020

Szelethus added a comment.

Alright, I'm up to speed I think, cheers!

In D79704#2037100 <https://reviews.llvm.org/D79704#2037100>, @NoQ wrote:

> > The code changes make me feel like we're doing a lot of chore (and make it super easy to forget checking for parameters explicitly).
>
> I wouldn't mind having a common base class for these regions. `DeclRegion` should probably be dropped in this case, in order to avoid dealing with multiple inheritance. And it's definitely the one that needs to be dropped because it currently does nothing except "inheritance for code reuse": there are basically no other common properties between its sub-classes than the accidental code reuse in its methods.

Totally. Something like a `VarRegionBase` but with a more clever name.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79704/new/

https://reviews.llvm.org/D79704