[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

Francesco Petrogalli via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 14 13:36:17 PDT 2020


fpetrogalli added inline comments.


================
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_mmla.c:17
+  // CHECK: ret <vscale x 4 x i32> %[[RET]]
+  return SVE_ACLE_FUNC(svmmla, _s32, , )(x, y, z);
+}
----------------
sdesmalen wrote:
> nit: please remove the whitespace between the commas (to make it similar to the other tests)
Done. May I ask the reason why this formatting is preferred? The command `git clang-format` prefers the one with spaces... 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79639/new/

https://reviews.llvm.org/D79639





More information about the cfe-commits mailing list