[PATCH] D79919: [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 14 10:50:24 PDT 2020


MaskRay marked an inline comment as done.
MaskRay added a comment.

Thanks for the review. Will remove D79916 <https://reviews.llvm.org/D79916> as a parent and commit this one first.



================
Comment at: clang/test/Driver/lto.c:52
+// RUN: %clang -target x86_64-unknown-linux-gnu --sysroot %S/Inputs/basic_cross_linux_tree %s \
+// RUN:   -fuse-ld=lld -flto -O -### 2>&1 | FileCheck --check-prefix=O1 %s
+// RUN: %clang -target x86_64-unknown-linux-gnu --sysroot %S/Inputs/basic_cross_linux_tree %s \
----------------
pcc wrote:
> I think this one should be `--check-prefix=O2`.
I added D79916 as a parent:)

Looks like I should just land this patch first and probably update the test in D79916.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79919/new/

https://reviews.llvm.org/D79919





More information about the cfe-commits mailing list