[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added inline comments.


================
Comment at: llvm/include/llvm/ADT/Triple.h:700
     return getArch() == Triple::r600 || getArch() == Triple::amdgcn;
   }
 
----------------
sameerds wrote:
> yaxunl wrote:
> > jdoerfert wrote:
> > > What's the difference between an AMDGPU and AMDGCN?
> > AMDGPU inlude r600 and amdgcn. r600 are old AMD GPUs. They do not support flat address space therefore cannot support CUDA or HIP.
> As a separate topic, does that mean that Clang should reject r600 at an earlier entry point itself?
I think HIP checks triple and rejects triple other than amdgcn


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79754/new/

https://reviews.llvm.org/D79754