[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally
Ten Tzen via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 13 23:57:37 PDT 2020
tentzen added a comment.
Hi, Is there more concern?
To re-iterate the implementation strategy of this change:
This is a rare case that only manifests itself under Windows SEH. We don't want to pollut target agnostic codes.
The ABI of SEH _finally is fixed with two implicit parameters; one abnormal execution and one establisher Stack-pointer. This ABI will never change, or a huge problem will arise.
CGF.LocalDeclMap is the fundamental data structure in Clang-CodeGen phase with one primary purpose, storing alloca instructions. Retrieving alloca of spilling instruction for 2nd implicit-argument from that data structure is legitimate and robust.
thanks,
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77982/new/
https://reviews.llvm.org/D77982
More information about the cfe-commits
mailing list