[PATCH] D79914: [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple.

Huihui Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 13 16:57:19 PDT 2020


huihuiz created this revision.
huihuiz added reviewers: efriedma, ekatz, rjmccall, rsmith, luismarques.
huihuiz added a project: LLVM.
Herald added subscribers: cfe-commits, jfb, kristof.beyls.
Herald added a project: clang.

Use explicit target triple to match more accurately the output for libcall
or native atomic.

Similar to D74847 <https://reviews.llvm.org/D74847>, without explicit target triple, this test will fail for ARM.

This patch update test pr45476.cpp to check for both native atomic and libcall.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79914

Files:
  clang/test/CodeGen/pr45476.cpp


Index: clang/test/CodeGen/pr45476.cpp
===================================================================
--- clang/test/CodeGen/pr45476.cpp
+++ clang/test/CodeGen/pr45476.cpp
@@ -1,4 +1,5 @@
-// RUN: %clang_cc1 -emit-llvm %s -o - | FileCheck %s
+// RUN: %clang_cc1 -triple arm-unknown-linux-gnueabi -emit-llvm %s -o - | FileCheck -check-prefix=LIBCALL %s
+// RUN: %clang_cc1 -triple armv8-eabi -emit-llvm %s -o - | FileCheck -check-prefix=NATIVE %s
 // PR45476
 
 // This test used to get into an infinite loop,
@@ -11,8 +12,10 @@
 _Atomic struct s3 a;
 
 extern "C" void foo() {
-  // CHECK-LABEL: @foo
-  // CHECK: store atomic i32
+  // LIBCALL-LABEL: @foo
+  // LIBCALL: call void @__atomic_store
+  // NATIVE-LABEL: @foo
+  // NATIVE: store atomic i32
 
   a = s3{1, 2, 3};
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79914.263890.patch
Type: text/x-patch
Size: 783 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200513/705dfb85/attachment.bin>


More information about the cfe-commits mailing list