[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

Wed May 13 15:16:57 PDT 2020

rjmccall added inline comments.

================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943
+  if (Opts.FastRelaxedMath)
+    Opts.setDefaultFPContractMode(LangOptions::FPM_Fast);
   Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat);
----------------
mibintc wrote:
> rjmccall wrote:
> > mibintc wrote:
> > > I changed this because the FAST version of this test clang/test/CodeGenOpenCL/relaxed-fpmath.cl wants the 'fast' attribute on the instruction dump.  All the LLVM FMF bits must be set for the fast attribute print.  By default, the value for OpenCL is ffp-contract=on
> > Is there an overall behavior change for OpenCL across these patches?
> I think the answer to your question is no.  Here is more details: OpenCL sets the default behavior to ffp-contract=on.  In https://reviews.llvm.org/D72841 I added the function UpdateFastMathFlags, that function set the llvm FMF.allowContract bit to be ( ffp-contract=on or ffp-contract=fast).  This patch just drops the check on ffp-contract=on.   I didn't wind back to see how the llvm fast attribute was being set for this [opencl] test case originally. 
Well, to what extent are there (including this patch) overall test changes for the OpenCL tests, and what are tthey?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79903/new/

https://reviews.llvm.org/D79903