[PATCH] D78120: [analyzer][StreamChecker] Don't make StreamTestChecker depend on StreamChecker for the time being

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 13 10:50:24 PDT 2020


Szelethus added a comment.

In D78120#2034455 <https://reviews.llvm.org/D78120#2034455>, @Szelethus wrote:

> In D78120#1983756 <https://reviews.llvm.org/D78120#1983756>, @balazske wrote:
>
> > LGTM
> >  But a better approach can be to make a new kind of dependency. (Or split the StreamChecker.)
>
>
> Definitely the latter, I just didn't wanna mess with your project :) But I'd be happy to assist in splitting it up eventually!


Just to clarify, I don't mean to push the implementation of the correct solution to somebody else, but StreamChecker is a moving target and splitting checkers up, as this project demonstrates, is about a few lines worth of work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78120/new/

https://reviews.llvm.org/D78120





More information about the cfe-commits mailing list