[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

It's tedious, but we really should have tests for this now.



================
Comment at: clang-tools-extra/clangd/index/remote/Index.proto:68
 
-// FIXME(kirillbobyrev): Properly serialize symbols and refs instead of passing
-// YAML.
-message Ref { string yaml_serialization = 1; }
-message Symbol { string yaml_serialization = 1; }
+message Symbol {
+  string id = 1;
----------------
somewhere in this file there should be a hint that semantics of all fields matches those in the structs in Index/


================
Comment at: clang-tools-extra/clangd/index/remote/Index.proto:70
+  string id = 1;
+  SymbolInfo info = 2;
+  string name = 3;
----------------
sigh, I wish we'd managed to get rid of this struct by now :-(
Maybe we can still do it before the 11 release


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79862/new/

https://reviews.llvm.org/D79862