[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

Francesco Petrogalli via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 13 08:05:28 PDT 2020


fpetrogalli added inline comments.


================
Comment at: clang/test/CodeGen/aarch64-bf16-getset-intrinsics.c:119-120
+// CHECK-LABEL: test_vduph_laneq_bf16
+// CHECK64: %vgetq_lane = extractelement <8 x bfloat> %v, i32 7
+// CHECK32: %vget_lane = extractelement <8 x bfloat> %v, i32 7
----------------
This seems to be the only place where you need to differentiate between check32 and check64, and I am not 100% sure the extra `q` in the name of the variable is relevant in terms of codegen testing.

Maybe you can just test both aarch32 and aarch64 with the same `CHECK` prefix?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79710/new/

https://reviews.llvm.org/D79710





More information about the cfe-commits mailing list