[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

[Leonard Chan via Phabricator via cfe-commits]

leonardchan added a comment.

This patch seems to lead to the undefined symbol error we're seeing when building fuchsia:

  ld.lld: error: relocation refers to a discarded section: __sancov_guards
  >>> defined in user-x64-sancov.shlib/obj/third_party/ulib/scudo/scudo.string_utils.cc.o
  >>> referenced by vector.h:58 (../../zircon/third_party/ulib/scudo/vector.h:58)
  >>>               user-x64-sancov.shlib/obj/third_party/ulib/scudo/scudo.string_utils.cc.o:(scudo::ScopedString::append(char const*, __va_list_tag*))
  >>> referenced by vector.h:58 (../../zircon/third_party/ulib/scudo/vector.h:58)
  >>>               user-x64-sancov.shlib/obj/third_party/ulib/scudo/scudo.string_utils.cc.o:(scudo::Printf(char const*, ...))

Checking to see if this is could be an us problem or something this patch introduced.

For reference: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8880544155798188656/+/steps/build/0/steps/build_fuchsia/0/steps/ninja/0/steps/zircon/0/logs/raw_io.output_failure_raw_summary_/0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79698/new/

https://reviews.llvm.org/D79698