[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata
Erich Keane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 12 08:01:58 PDT 2020
erichkeane added a comment.
It doesn't seem like it would be much work to move the EmitTargetMetadata function into the TargetInfo object (as a virtual function taking a reference to the collection). Essentially, have this take a reference to the collection instead of the 'D' and 'GV'.
I say that, because to me it seems that this check should likely be a part of that EmitTargetMetadata calling process (meaning, GV! = null is a precondition of this function).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77068/new/
https://reviews.llvm.org/D77068
More information about the cfe-commits
mailing list