[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

[Matt Arsenault via Phabricator via cfe-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:75
+    // The desired structure is (${ROCM_ROOT} or
+    // ${OPENCL_ROOT})/amdgcn/bitcode/*, so try to detect this layout.
 
----------------
yaxunl wrote:
> with your change, the structure becomes
> 
> ${ROCM_ROOT}/amdgcn/bitcode/*.bc
> 
> Does the toolchain support ${OPENCL_ROOT} ?
This is just pseudocode and no environment variable is read. This corresponds to --rocm-path


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77885/new/

https://reviews.llvm.org/D77885