[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

[Puyan Lotfi via Phabricator via cfe-commits]

plotfi added a comment.

@rjmccall @mibintc I think the diagnostics-order.c test is still behaving correctly technically. The note lines are still printing with the associated error lines, it just happens that one of the warning lines prints at the end instead of in the middle. ie:

  error: invalid value '-foo' in '-verify='
  note: -verify prefixes must start with a letter and contain only alphanumeric characters, hyphens, and underscores
  error: invalid value 'bogus' in '-std=bogus'
  note: use 'c89', 'c90', or 'iso9899:1990' for 'ISO C 1990' standard
  ...
  warning: optimization level '-O999' is not supported; using '-O3' instead

instead of

  error: invalid value '-foo' in '-verify='
  note: -verify prefixes must start with a letter and contain only alphanumeric characters, hyphens, and underscores
  warning: optimization level '-O999' is not supported; using '-O3' instead
  error: invalid value 'bogus' in '-std=bogus'
  note: use 'c89', 'c90', or 'iso9899:1990' for 'ISO C 1990' standard
  ...



In D72841#2030468 <https://reviews.llvm.org/D72841#2030468>, @plotfi wrote:

> That was a good fix. I am pretty sure this does mean the diagnostics-order.c will fail on apple's bots. The same diagnostics lines print, but in the wrong order. I haven't root caused that yet.
>
> In D72841#2030099 <https://reviews.llvm.org/D72841#2030099>, @mibintc wrote:
>
> > In D72841#2029821 <https://reviews.llvm.org/D72841#2029821>, @plotfi wrote:
> >
> > > @ab @rjmccall @mibintc Posted D79730 <https://reviews.llvm.org/D79730> for consideration.
> > >  @mibintc can you produce a version of _this_ diff that works with D79730 <https://reviews.llvm.org/D79730> applied. Currently the following fail, as they do on Apple Master:
> >
> >
> > @rjmccall accepted the proposed patch https://reviews.llvm.org/D79735, so I pushed that.  I also tried your patch and the 3 CodeGen tests pass but the diagnostics-order.c test fails
> >
> > > 
> > > 
> > >   Failing Tests (4):
> > >     Clang :: CodeGen/finite-math.c
> > >     Clang :: CodeGen/fp-floatcontrol-stack.cpp
> > >     Clang :: CodeGenOpenCL/relaxed-fpmath.cl
> > >     Clang :: Frontend/diagnostics-order.c
>





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72841/new/

https://reviews.llvm.org/D72841