[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

Dávid Bolvanský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 11 12:23:14 PDT 2020


xbolva00 marked an inline comment as done.
xbolva00 added inline comments.


================
Comment at: clang/test/SemaCXX/deprecated-copy.cpp:7
+#ifdef NO_USER_PROVIDED
+// expected-no-diagnostics
+#endif
----------------
xbolva00 wrote:
> Quuxplusone wrote:
> > I'm fairly confident this should just be two different test files. Also, if a test file has an un-ifdeffed `// expected-no-diagnostics` plus an un-ifdeffed `// expected-note ...`, which one wins?
> ifdef is here
> 
> and ifNdef is below :)
and DEPRECATED_COPY_DTOR is in own "code block"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79714/new/

https://reviews.llvm.org/D79714





More information about the cfe-commits mailing list