[PATCH] D60193: [OpenCL] Added addrspace_cast operator
Marco Antognini via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 11 02:06:52 PDT 2020
mantognini accepted this revision.
mantognini added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/test/SemaOpenCLCXX/addrspace_cast.cl:19-24
+template <class T>
+void test_temp(__global int *par) {
+ T *var1 = addrspace_cast<T *>(par);
+ __private T *var2 = addrspace_cast<__private T *>(par);
+ T var3 = addrspace_cast<T>(par);
+}
----------------
Anastasia wrote:
> mantognini wrote:
> > Does this test anything since it's not instantiated?
> It tests AST creation and Sema but not after the TreeTransforms. I have now enhanced it.
It is now much clearer.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60193/new/
https://reviews.llvm.org/D60193
More information about the cfe-commits
mailing list