[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

Sun May 10 21:17:07 PDT 2020

plotfi added a comment.

@rjmccall @mibintc Can we revert this patch for now then, and re-land when this patch is reworked? It would be good to get those bots passing. @rjmccall are the bots that you see failing on your end public?

In D72841#2028834 <https://reviews.llvm.org/D72841#2028834>, @rjmccall wrote:

> In D72841#2027740 <https://reviews.llvm.org/D72841#2027740>, @plotfi wrote:
>
> > Hi @rjmccall, I am also seeing similar failures. It is failing on apple's master (and the swift branches as well) because ParseLangArgs and ParseCodeGenArgs are getting called in the opposite order in apple/master from the order they are called in llvm/master. I posted a PR to fix those failures here: https://github.com/apple/llvm-project/pull/1202
> >
> > but I don't know if this is the most correct approach.
>
>
> Oh, thank you for figuring that out.  Yeah, it's reasonable for code-gen option parsing to depend on language-option parsing, which means that this patch is wrong.  The right fix is that we need to stop parsing these as code-gen options, which is reasonable since they have direct language-semantics impact.  If we still need the code-gen option flags, we should be able to recreate them from the language options, I think.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72841/new/

https://reviews.llvm.org/D72841