[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

[hyd-dev via Phabricator via cfe-commits]

hyd-dev added a comment.

> Would a test case be needed?

`clang::tidy::clangTidyMain()` shows that clang-tidy reports all diagnostics by  `clang::tidy::handleErrors()`, which constructs a `clang::tidy::(anonymous namespace)::ErrorReporter`, no matter where they come from, so I think a test case is not required.

> Not a fan of this test case as it only demonstrates the color behaviour of the process running the check not the actual option itself

What does "option itself" mean?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79477/new/

https://reviews.llvm.org/D79477