[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

Puyan Lotfi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 8 15:03:57 PDT 2020


plotfi added a comment.

Hi @rjmccall, I am also seeing similar failures. It is failing on apple's master (and the swift branches as well) because ParseLangArgs and ParseCodeGenArgs are getting called in the opposite order in apple/master from the order they are called in llvm/master. I posted a PR to fix those failures here: https://github.com/apple/llvm-project/pull/1202

but I don't know if this is the most correct approach.

In D72841#2023058 <https://reviews.llvm.org/D72841#2023058>, @rjmccall wrote:

> We're also seeing test failures in Apple's Clang fork, e.g.
>
>   test/CodeGen/finite-math.c:12:10: error: NSZ: expected string not found in input
>    // NSZ: fadd nsz
>            ^
>   <stdin>:11:20: note: scanning from here
>   define void @foo() #0 {
>                      ^
>   <stdin>:15:9: note: possible intended match here
>    %add = fadd float %0, %1
>           ^
>
>
> I haven't checked yet whether we can reproduce upstream.





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72841/new/

https://reviews.llvm.org/D72841





More information about the cfe-commits mailing list