[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

Thu May 7 15:14:26 PDT 2020

tra added a comment.

In D79344#2026126 <https://reviews.llvm.org/D79344#2026126>, @hliao wrote:

> In D79344#2026025 <https://reviews.llvm.org/D79344#2026025>, @tra wrote:
>
> > We're calling `copysign( int, double)`. The standard library provides `copysign(double, double)`, CUDA provides only `copysign(float, double)`.  As far as C++ is concerned, both require one type conversion. I guess previously we would give `__device__` one provided by CUDA a higher preference, considering that the callee is a device function. Now both seem to have equal weight. I'm not sure how/why,
>
>
> @yaxunl, that may be related to the change of overload resolution. Back to this change, that error should not be related to the non-local variable checks.

The tree I've tested had Sam's changes reverted (bf6a26b066382e0f41bf023c781d84061c542307 <https://reviews.llvm.org/rGbf6a26b066382e0f41bf023c781d84061c542307>), so it appears to be triggered by this patch. Let me try reproducing it in the upstream HEAD.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79344/new/

https://reviews.llvm.org/D79344