[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

[Artem Belevich via Phabricator via cfe-commits]

tra added a comment.

In D79344#2018915 <https://reviews.llvm.org/D79344#2018915>, @tra wrote:

> If you can wait, I can try patching this change into our clang tree and then see if it breaks anything obvious. If nothing falls apart, I'll be fine with the patch as is.


The patch appears to break compilation of CUDA headers:

  In file included from <built-in>:1:
  In file included from llvm_unstable/toolchain/lib/clang/google3-trunk/include/__clang_cuda_runtime_wrapper.h:406:
  llvm_unstable/toolchain/lib/clang/google3-trunk/include/__clang_cuda_complex_builtins.h:30:13: error: call to 'copysign' is ambiguous
        __a = std::copysign(std::isinf(__a) ? 1 : 0, __a);
              ^~~~~~~~~~~~~
  llvm_unstable/toolchain/lib/clang/google3-trunk/include/__clang_cuda_math.h:76:19: note: candidate function
  __DEVICE__ double copysign(double __a, double __b) {
                    ^
  third_party/gpus/cuda_10_1/include/crt/math_functions.hpp:861:32: note: candidate function
  __MATH_FUNCTIONS_DECL__ double copysign(float a, double b)
                                 ^
  1 error generated when compiling for sm_60.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79344/new/

https://reviews.llvm.org/D79344