[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay planned changes to this revision.
MyDeveloperDay marked an inline comment as done.
MyDeveloperDay added inline comments.


================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2405
                             tok::kw___attribute, tok::kw___declspec,
-                            tok::kw_alignas) ||
+                            tok::kw_alignas, tok::l_square) ||
          ((Style.Language == FormatStyle::LK_Java ||
----------------
krasimir wrote:
> Just to make sure I follow -- at this point why can't we check for the more specific `TT_AttributeSquare` instead of the general `tok::l_square` (if that's available, not sure when it gets computed) (`isOneOf` accepts both `tok::`'s and `TT_`'s). 
> 
> Ditto for the new `tok::l_square` below.
You are quite correct I can use TT_AttributeSquare here... let me change that


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79354/new/

https://reviews.llvm.org/D79354