[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority
Zarko Todorovski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 7 07:54:18 PDT 2020
ZarkoCA added inline comments.
================
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:691
AddGlobalDtor(Fn);
+ CXXGlobalDtors.clear();
}
----------------
I may be missing something but why do we need this now, as opposed to not needing it before? Why didn't we need to clear the CXXGlobalDtors after emitting the function function before?
================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4442
+ if (D.getTLSKind() != VarDecl::TLS_None)
+ llvm::report_fatal_error("Thread local storage unimplemented on AIX yet.");
+
----------------
Style guide now says no capitalization and no punctuation at the end for `report_fatal_error` messages.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74166/new/
https://reviews.llvm.org/D74166
More information about the cfe-commits
mailing list