[PATCH] D79510: [PATCH] When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures

Melanie Blower via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 6 12:26:02 PDT 2020


mibintc marked 2 inline comments as done.
mibintc added inline comments.


================
Comment at: clang/lib/Parse/ParsePragma.cpp:111
       PP.Diag(Tok, diag::warn_stdc_fenv_access_not_supported);
+      return;
     }
----------------
Modified this to return instead of making changes which will ultimately modify the floating point state


================
Comment at: clang/test/CodeGen/fp-floatcontrol-pragma.cpp:61
+  z = z * z;
+//CHECK: = fmul float
+}
----------------
I used a modified version of @uabelho 's test. I verified that before this bug fix a constrained intrinsic was being created for this multiply.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79510/new/

https://reviews.llvm.org/D79510





More information about the cfe-commits mailing list