[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens
MyDeveloperDay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 6 10:46:47 PDT 2020
MyDeveloperDay added a comment.
In D78869#2022850 <https://reviews.llvm.org/D78869#2022850>, @mitchell-stellar wrote:
> I often:
I develop and run on windows (using a cygwin shell), but with visual studio compiler (configured with CMake for ninja)
0.5 after doing git add of the files, I do `git clang-format` just to be sure (adding any files that are modified)
> 1. Commit the change to my local repo, following the style of previous commit messages for clang-format.
So I have a script which gets the commit message
get_commit_message.sh
----
echo '{ "revision_id": '${1:1}' }' | arc call-conduit --conduit-uri https://reviews.llvm.org/ --conduit-token <phabricator-token> differential.getcommitmessage | /usr/bin/jq -r ".response"
---
This will fetch the commit message from Phabricator that I should use. (you need to get a phabricator-token from your profile->settings)
git fetch && git pull --rebase --autostash
> 2. Build and run the clang-format tests and make sure they pass.
> 3. Pull, rebase, and push. (Linear history is enforced.)
> 4. Build and run the clang-format tests again just in case. (Optional)
5. I try to run the lit tests too. (in clang/tests/Format)
6. I check the documentation if any rst files are changed ( /usr/bin/sphinx-build -n ./docs ./html)
// assuming no new changes.. git push
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78869/new/
https://reviews.llvm.org/D78869
More information about the cfe-commits
mailing list