[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

Wed May 6 09:40:37 PDT 2020

leonardchan added a comment.

In D79445#2021502 <https://reviews.llvm.org/D79445#2021502>, @aeubanks wrote:

> In D79445#2021311 <https://reviews.llvm.org/D79445#2021311>, @leonardchan wrote:
>
> > In `addSanitizersAtO0`, could you make something similar to the `ASanPass` lambda for the MSan passes and also apply it when adding kernel MSan?
>
>
> It ends up calling an extra `MPM.addPass(createModuleToFunctionPassAdaptor())` in the `KernelMemory` case, is that okay?

Didn't notice that at first. What you originally had seems ok then if there wasn't already a module adaptor for the pass;

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79445/new/

https://reviews.llvm.org/D79445