[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added a comment.

Overall looks good to me, I have one question inline.



================
Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1013
+    addToFunctionSummaryMap(
+        "__buf_size_arg_constraint_mul",
+        Summary(ArgTypes{ConstVoidPtrTy, SizeTy, SizeTy}, RetType{IntTy},
----------------
Why do we need these test functions? Above I saw `fread` as an example that requires this capability. Wouldn't it be better to make its summary utilize the new feature and use `fread` in tests? Do I miss something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77148/new/

https://reviews.llvm.org/D77148