[PATCH] D78190: Add Bfloat IR type

Ties Stuij via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 5 10:14:27 PDT 2020


stuij added a comment.

In D78190#2020701 <https://reviews.llvm.org/D78190#2020701>, @stuij wrote:

> In D78190#2018685 <https://reviews.llvm.org/D78190#2018685>, @fpetrogalli wrote:
>
> > 3. Do you need those changes in the Hexagon and x86 backend? Could they be submitted separately, with some testing?
>
>
> This is a backend agnostic patch. If the Hexagon and/or x86 communities want to make use of the IR type in some way, then yes, they can for sure submit the necessary patches.


Ah sorry, I misread your comment. You're talking about the hexagon/x86 changes in this patch. They're there because of interface changes: the x86 change is because of the getAllOnesValue arguments have changed. The hexagon one is there to squash a warning because we added the bfloat Type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78190/new/

https://reviews.llvm.org/D78190





More information about the cfe-commits mailing list