[PATCH] D79380: [clang-tidy] In TransformerClangTidyCheck, support option SourceNamingStyle.

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 5 05:53:05 PDT 2020


gribozavr2 added a comment.

> It's only effect is to determine how a given file is related to header files, specifically how to determine that a header "corresponds" to a the file being examined -- that is, it is _this_ file's header rather than some arbitrary header.

... and the results of that algorithm directly affect how the includes are sorted. We could also conceivably get more styles in IncludeSorter that affect how headers are sorted (for example, related to case sensitivity).

Although I personally don't think this option is misnamed, I can see your point though. But given that the current name is used in many existing checkers, I don't think we should diverge in this patch. I think the right way would be to rename the option consistently everywhere, and to maintain a compatibility alias with a warning for at least one release.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79380/new/

https://reviews.llvm.org/D79380





More information about the cfe-commits mailing list