[PATCH] D76646: Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 5 04:48:39 PDT 2020
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from the formatting nits. I think this is a nice cleanup, thanks!
================
Comment at: clang/include/clang/AST/Expr.h:503
- /// isIntegerConstantExpr - Return true if this expression is a valid integer
- /// constant expression, and, if so, return its value in Result. If not a
- /// valid i-c-e, return false and fill in Loc (if specified) with the location
- /// of the invalid expression.
+ /// isIntegerConstantExpr - Return the value if this expression is a valid integer
+ /// constant expression. If not a valid i-c-e, return None and fill in Loc
----------------
80-col issue, should clang-format the patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76646/new/
https://reviews.llvm.org/D76646
More information about the cfe-commits
mailing list