[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

Some part of me wishes we could use expression profiling or ODR hashing or something like that for this, but I guess the semantics we're going for don't really match.



================
Comment at: clang/lib/Sema/SemaExprObjC.cpp:948
+        checkOneKey(IntegralKeys, Result.Val.getInt(), Loc);
+      }
+    }
----------------
Does `EvaluateAsInt` really just fail cleanly if the argument doesn't have integral type?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78660/new/

https://reviews.llvm.org/D78660