[PATCH] D79054: [NFC] Improve documentation for -i and update example git one liner

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 4 15:05:30 PDT 2020


efriedma added a comment.

We should probably encourage people to use git-clang-format with git repositories.  It naturally doesn't have this sort of fragility because it integrates with the repository more tightly.



================
Comment at: clang/tools/clang-format/clang-format-diff.py:41
+                      ' The filename contained in the diff is used unmodified'
+                      ' to determine the source file to update')
   parser.add_argument('-p', metavar='NUM', default=0,
----------------
That isn't specific to -i. If you look more carefully at what the command is doing, it always goes back to the original source file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79054/new/

https://reviews.llvm.org/D79054





More information about the cfe-commits mailing list