[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added inline comments.


================
Comment at: clang/test/SemaCUDA/variable-target.cu:42
+  return 0;
+}
----------------
hliao wrote:
> yaxunl wrote:
> > we need to have a test to check captured local host variable is allowed in device lambda.
> > 
> > we need to have some test for constexpr variables used in device function.
> This patch just addresses the direct address of variables. For capture, it would be better to start with another patch.
but there are chances that this patch may break valid usage of captured variables in device lambda. At least we should add test to avoid that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79344/new/

https://reviews.llvm.org/D79344