[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

[Kim Viggedal via Phabricator via cfe-commits]

vingeldal added a comment.

In D79113#2016294 <https://reviews.llvm.org/D79113#2016294>, @aaron.ballman wrote:

> I only see a comment on the issue, but not that the issue was resolved in favor of that comment (unless I've missed something). If the issue gets resolved in the direction that comment is going, then the revert makes sense (though we should add an explicit test case showing that we want the diagnostic).


No, your not missing anything. The issue isn't actually closed yet. I'll remember to update tests as appropriate if the issue is resolved in favor of this revert. Until the issue is resolved I'll just wait.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79113/new/

https://reviews.llvm.org/D79113