[PATCH] D79315: [clangd] Get rid of Inclusion::R

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 4 09:37:48 PDT 2020


kadircet marked 4 inline comments as done.
kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/XRefs.cpp:610
+    auto FileRange =
+        syntax::FileRange(SM, FileTok->location(), Inc.Written.length())
+            .toCharRange(SM);
----------------
sammccall wrote:
> is this just FileTok.range(SM)?
unfortunately it is not. as raw lexing doesn't parse angled filename tokens(it will just point to the `lessthan` token). Adding a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79315/new/

https://reviews.llvm.org/D79315





More information about the cfe-commits mailing list